Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINID and LIMIT support for xtrim #1508

Merged
merged 4 commits into from
Aug 15, 2021
Merged

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Jul 14, 2021

Part of the new commands in #1434

Fixed #1454

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Adds support for the new minid, and limit args to xtrim. To ensure no API changes broke anything both minid and limit arguments were added to the end of the function.

@chayim chayim requested a review from andymccurdy July 15, 2021 07:16
redis/client.py Show resolved Hide resolved
@chayim chayim requested review from abrookins and removed request for andymccurdy July 25, 2021 09:25
@chayim chayim merged commit e498182 into redis:master Aug 15, 2021
@chayim chayim deleted the ck-xtrim-minlen-length branch August 15, 2021 10:46
Andrew-Chen-Wang added a commit to aio-libs-abandoned/aioredis-py that referenced this pull request Oct 8, 2021
MINID and LIMIT support for xtrim (redis/redis-py#1508)

Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XTRIM - MINID as in redis 6.2.0
2 participants